New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] don't lose int precision with not needed type casts #30063

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

xabbuh commented Feb 2, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26795
License MIT
Doc PR
@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Feb 2, 2019

Looks like the fix does not work on all platforms.

Status: Needs work

@xabbuh xabbuh force-pushed the xabbuh:issue-26795 branch from 971f7ff to 55676ba Feb 4, 2019

@xabbuh xabbuh force-pushed the xabbuh:issue-26795 branch from 55676ba to 72136f1 Feb 4, 2019

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Feb 4, 2019

Status: Needs review

@xabbuh xabbuh force-pushed the xabbuh:issue-26795 branch from 4065546 to 72136f1 Feb 4, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 8, 2019

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 72136f1 into symfony:3.4 Feb 8, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 8, 2019

bug #30063 [Form] don't lose int precision with not needed type casts…
… (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] don't lose int precision with not needed type casts

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26795
| License       | MIT
| Doc PR        |

Commits
-------

72136f1 don't lose int precision with not needed type casts

@xabbuh xabbuh deleted the xabbuh:issue-26795 branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment