New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] Added information about deprecated aliases in debug:autowiring #30075

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@XuruDragon
Copy link
Contributor

XuruDragon commented Feb 4, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR n/a

Fix and improves a bit PR #29968 and #29995

Screenshot

@XuruDragon XuruDragon force-pushed the XuruDragon:deprecated-aliases branch from 42a3c16 to 4b17a3b Feb 4, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Feb 4, 2019

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

Thanks!
Can you please share a screenshot?
It'd be nice to add some tests also.

@XuruDragon XuruDragon force-pushed the XuruDragon:deprecated-aliases branch from 4b17a3b to 82ce6e7 Feb 4, 2019

@XuruDragon

This comment has been minimized.

Copy link
Contributor Author

XuruDragon commented Feb 4, 2019

Thanks!
Can you please share a screenshot?
It'd be nice to add some tests also.

Screenshot added.
Tests already existing, added by #29968, I've fixed one of them.

@XuruDragon XuruDragon force-pushed the XuruDragon:deprecated-aliases branch 3 times, most recently from a57ce22 to e724fbd Feb 4, 2019

@XuruDragon XuruDragon force-pushed the XuruDragon:deprecated-aliases branch 4 times, most recently from 1df769c to ba10a39 Feb 6, 2019

[DependencyInjection] Added information about deprecated aliases in d…
…ebug:autowiring

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | n/a

Fix and improves a bit PR #29968 and #29995

@XuruDragon XuruDragon force-pushed the XuruDragon:deprecated-aliases branch from ba10a39 to 3d2378d Feb 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 8, 2019

Thank you @XuruDragon.

@nicolas-grekas nicolas-grekas merged commit 3d2378d into symfony:master Feb 8, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 8, 2019

feature #30075 [DependencyInjection] Added information about deprecat…
…ed aliases in debug:autowiring (XuruDragon)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[DependencyInjection] Added information about deprecated aliases in debug:autowiring

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | n/a

Fix and improves a bit PR #29968 and #29995

![Screenshot](https://i.imgur.com/GDj2NIY.png)

Commits
-------

3d2378d [DependencyInjection] Added information about deprecated aliases in debug:autowiring

@XuruDragon XuruDragon deleted the XuruDragon:deprecated-aliases branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment