Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] ignore _method forms in NativeRequestHandler #30076

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

commented Feb 4, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #19017
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Feb 4, 2019

@xabbuh xabbuh force-pushed the xabbuh:issue-19017 branch from 32093b9 to bc4b091 Feb 4, 2019

@HeahDude
Copy link
Member

left a comment

Looks like a reasonable fix to keep BC without adding too much complexity.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit bc4b091 into symfony:3.4 Feb 8, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 8, 2019

bug #30076 [Form] ignore _method forms in NativeRequestHandler (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] ignore _method forms in NativeRequestHandler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19017
| License       | MIT
| Doc PR        |

Commits
-------

bc4b091 ignore _method forms in NativeRequestHandler

@xabbuh xabbuh deleted the xabbuh:issue-19017 branch Feb 8, 2019

This was referenced Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.