Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Fix DataCollector template #30078

Merged

Conversation

Projects
None yet
7 participants
@ottaviano
Copy link
Contributor

ottaviano commented Feb 5, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

It's for adding a closing DIV tag on L96 (+ re-indent the HTML code)

@ro0NL

ro0NL approved these changes Feb 5, 2019

@Kronhyx
Copy link

Kronhyx left a comment

I have doubts

<div class="tab">
{% set messages = collector.messages %}
{% set exceptionsCount = collector.exceptionsCount %}
<h3 class="tab-title">All<span class="badge {{ exceptionsCount ? exceptionsCount == messages|length ? 'status-error' : 'status-some-errors' }}">{{ messages|length }}</span></h3>

This comment has been minimized.

Copy link
@Kronhyx

Kronhyx Feb 5, 2019

Taking advantage of the fact that you are refactoring why you do not use a strict comparison?

Suggested change
<h3 class="tab-title">All<span class="badge {{ exceptionsCount ? exceptionsCount == messages|length ? 'status-error' : 'status-some-errors' }}">{{ messages|length }}</span></h3>
<h3 class="tab-title">All<span class="badge {{ exceptionsCount ? exceptionsCount === messages|length ? 'status-error' : 'status-some-errors' }}">{{ messages|length }}</span></h3>

This comment has been minimized.

Copy link
@xabbuh

xabbuh Feb 5, 2019

Member

Twig doesn't have a === operator.

This comment has been minimized.

Copy link
@Kronhyx

Kronhyx Feb 6, 2019

haha ... ups ... I missed it ... hehe

This comment has been minimized.

Copy link
@stloyd

stloyd Feb 6, 2019

Contributor

But it has:

exceptionsCount is same as (messages|length)

No sure it worth using it here anyway.

@Kronhyx

Kronhyx approved these changes Feb 6, 2019

@xabbuh

xabbuh approved these changes Feb 6, 2019

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Feb 7, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 7, 2019

Thank you @ottaviano.

@nicolas-grekas nicolas-grekas merged commit 146ae74 into symfony:4.2 Feb 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 7, 2019

bug #30078 [Messenger] Fix DataCollector template (ottaviano)
This PR was merged into the 4.2 branch.

Discussion
----------

[Messenger] Fix DataCollector template

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

It's for adding a closing DIV tag on L96 (+ re-indent the HTML code)

Commits
-------

146ae74 [Messenger] Fix DataCollector template

@fabpot fabpot referenced this pull request Mar 3, 2019

Merged

Release v4.2.4 #30431

@ottaviano ottaviano deleted the ottaviano:fix-messenger-data-collector-template branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.