New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] fix PHP 5.3 compat #30087

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 6, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

ONLY FOR 3.4
The bridge must remain compatible with PHP 5.3
Introduced in 33a001e.

if (self::MODE_DISABLED !== $mode
&& self::MODE_WEAK !== $mode
&& self::MODE_WEAK_VENDORS !== $mode
if (DeprecationErrorHandler::MODE_DISABLED !== $mode

This comment has been minimized.

@xabbuh

xabbuh Feb 6, 2019

Member

This change isn't needed, is it?

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Feb 6, 2019

Author Member

That's precisely the line where it fails first :)
https://travis-ci.org/symfony/polyfill/jobs/489417717

This comment has been minimized.

@xabbuh

xabbuh Feb 6, 2019

Member

oh PHP 5.3 :o

@xabbuh

xabbuh approved these changes Feb 6, 2019

@nicolas-grekas nicolas-grekas merged commit b45cbf6 into symfony:3.4 Feb 7, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

nicolas-grekas added a commit that referenced this pull request Feb 7, 2019

bug #30087 [PhpUnitBridge] fix PHP 5.3 compat (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] fix PHP  5.3 compat

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

ONLY FOR 3.4
The bridge must remain compatible with PHP 5.3
Introduced in 33a001e.

Commits
-------

b45cbf6 [PhpUnitBridge] fix PHP  5.3 compat

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:phpunit-fix branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment