New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] replace mocks with real objects in tests #30108

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

xabbuh commented Feb 7, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Feb 7, 2019

@xabbuh xabbuh force-pushed the xabbuh:form-remove-mocks branch 2 times, most recently from 942d1fc to d0e01ea Feb 7, 2019

@xabbuh xabbuh force-pushed the xabbuh:form-remove-mocks branch from d0e01ea to 6ac2550 Feb 7, 2019

@xabbuh

This comment has been minimized.

Copy link
Member Author

xabbuh commented Feb 8, 2019

Actually, there are still lots of them. I tried to clean up namespace by namespace. No idea when I will have the time to update the rest. So I think we can still merge this PR and I will then at some point in the future create a follow-up PR.

@OskarStark
Copy link
Contributor

OskarStark left a comment

Great work 👏

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 8, 2019

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 6ac2550 into symfony:3.4 Feb 8, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 8, 2019

minor #30108 [Form] replace mocks with real objects in tests (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] replace mocks with real objects in tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

6ac2550 replace mocks with real objects in tests

@xabbuh xabbuh deleted the xabbuh:form-remove-mocks branch Feb 8, 2019

nicolas-grekas added a commit that referenced this pull request Feb 8, 2019

minor #30113 [Form] replace mocks with real objects in tests (xabbuh)
This PR was merged into the 4.2 branch.

Discussion
----------

[Form] replace mocks with real objects in tests

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

reapplies parts of #30108 on the `4.2` branch

Commits
-------

cee3ccd replace mocks with real objects in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment