New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] Deprecate the normalization of the cookie names #30111

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
5 participants
@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 8, 2019

Q A
Branch? master
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This is an alternative solution to #24018 providing a BC layer until Symfony 5.0.

@javiereguiluz javiereguiluz added this to the next milestone Feb 8, 2019

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

(worth an entry in CHANGELOG+UPGRADING files?)

@javiereguiluz javiereguiluz changed the title [SecurityBundle] Don't normalize the names of the cookies to delete [SecurityBundle] Deprecate the normalization of the cookie names Feb 8, 2019

@fabpot

fabpot approved these changes Feb 12, 2019

@fabpot fabpot force-pushed the javiereguiluz:fix_24018 branch from ef133dc to 36c5df4 Feb 12, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 12, 2019

Thank you @javiereguiluz.

@fabpot fabpot merged commit 36c5df4 into symfony:master Feb 12, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 12, 2019

feature #30111 [SecurityBundle] Deprecate the normalization of the co…
…okie names (javiereguiluz)

This PR was squashed before being merged into the 4.3-dev branch (closes #30111).

Discussion
----------

[SecurityBundle] Deprecate the normalization of the cookie names

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is an alternative solution to #24018 providing a BC layer until Symfony 5.0.

Commits
-------

36c5df4 [SecurityBundle] Deprecate the normalization of the cookie names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment