New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "internal" annotation from datacollector serialization methods #30112

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 8, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

I've been a bit too aggressively adding @internal in #30035.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 8, 2019

@nicolas-grekas nicolas-grekas merged commit 3c8fd20 into symfony:3.4 Feb 8, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 8, 2019

minor #30112 Remove "internal" annotation from datacollector serializ…
…ation methods (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

Remove "internal" annotation from datacollector serialization methods

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I've been a bit too aggressively adding `@Internal` in #30035.

Commits
-------

3c8fd20 Remove "internal" annotation from datacollector serialization methods

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:datacoll-not-internal branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment