New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] add missing null return type #30119

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

xabbuh commented Feb 8, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This reflects how all our implementations of this interface actually behave.

@xabbuh xabbuh added this to the 3.4 milestone Feb 8, 2019

@xabbuh xabbuh merged commit 03abfc0 into symfony:3.4 Feb 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

xabbuh added a commit that referenced this pull request Feb 11, 2019

minor #30119 [Form] add missing null return type (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] add missing null return type

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This reflects how all our implementations of this interface actually behave.

Commits
-------

03abfc0 add missing null return type

@xabbuh xabbuh deleted the xabbuh:form-type-guesser-return-type branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment