New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][Translation] Added support for PHP files with trans() in translation commands #30120

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
None yet
4 participants
@yceruto
Copy link
Contributor

yceruto commented Feb 8, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29085
License MIT
Doc PR -

This PR allows translation commands be able to debug and update translation messages from any PHP file/class defined as service, injecting or wiring the translator service, e.g.:

use Symfony\Component\Translation\TranslatorInterface;

class ParallelUniverseController extends AbstractController
{
    public function hello(Request $request, TranslatorInterface $translator)
    {
        // this id 'hello_message' will be extracted from translation:update
        $message = $translator->trans('hello_message'); 

        // send message to space...
    }
}

this supports all ways of wiring (auto or not): via constructor, public property, method calls, service subscriber and controller argument.

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 13, 2019

#29121 is now merged, can be rebased.

@yceruto yceruto force-pushed the yceruto:add_php_files_support branch from 18a570a to 9f9b828 Feb 14, 2019

@yceruto

This comment has been minimized.

Copy link
Contributor Author

yceruto commented Feb 14, 2019

Rebased (Travis failure is unrelated), ready on my side, thanks.

@fabpot

fabpot approved these changes Feb 14, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 16, 2019

Thank you @yceruto.

@fabpot fabpot merged commit 9f9b828 into symfony:master Feb 16, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 16, 2019

feature #30120 [FrameworkBundle][Translation] Added support for PHP f…
…iles with trans() in translation commands (yceruto)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle][Translation] Added support for PHP files with trans() in translation commands

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29085
| License       | MIT
| Doc PR        | -

This PR allows translation commands be able to debug and update translation messages from any PHP file/class defined as service, injecting or wiring the `translator` service, e.g.:
```php
use Symfony\Component\Translation\TranslatorInterface;

class ParallelUniverseController extends AbstractController
{
    public function hello(Request $request, TranslatorInterface $translator)
    {
        // this id 'hello_message' will be extracted from translation:update
        $message = $translator->trans('hello_message');

        // send message to space...
    }
}
```
this supports all ways of wiring (auto or not): via constructor, public property, method calls, service subscriber and controller argument.

Commits
-------

9f9b828 Added support for PHP files with translation in translation commands

@yceruto yceruto deleted the yceruto:add_php_files_support branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment