New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] fix switch user without having current token #30122

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
8 participants
@alamirault
Copy link

alamirault commented Feb 8, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22729
License MIT

Attempting to switch a user cause an error when not having any token in the storage

@alamirault alamirault force-pushed the alamirault:nauth_switch_user branch from 27006ca to 5c275d0 Feb 8, 2019

@alamirault alamirault force-pushed the alamirault:nauth_switch_user branch from 5c275d0 to 15db914 Feb 9, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 10, 2019

@xabbuh

xabbuh approved these changes Feb 10, 2019

@fabpot

fabpot approved these changes Feb 12, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 12, 2019

Thank you @alamirault.

@fabpot fabpot merged commit 15db914 into symfony:3.4 Feb 12, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 12, 2019

bug #30122 [Security] fix switch user without having current token (A…
…ntoine Lamirault)

This PR was merged into the 3.4 branch.

Discussion
----------

[Security] fix switch user without having current token

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22729
| License       | MIT

Attempting to switch a user cause an error when not having any token in the storage

Commits
-------

15db914 [Security] fix switch user without having current token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment