New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KernelTestCase compatibility for PhpUnit 8 (bis) #30124

Merged
merged 1 commit into from Feb 12, 2019

Conversation

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Feb 9, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Follow up of #30084 and @Tobion's comment there.

Fabbot failure is a false-positive.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 9, 2019

@nicolas-grekas nicolas-grekas changed the title Phpunit8 Fix KernelTestCase compatibility for PhpUnit 8 (bis) Feb 9, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:phpunit8 branch from 1647a11 to 0ed30bb Feb 9, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:phpunit8 branch from 0ed30bb to d18a2d8 Feb 9, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:phpunit8 branch from d18a2d8 to 8324cd6 Feb 10, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Feb 10, 2019

Comments addressed, thanks for the review.

@xabbuh

xabbuh approved these changes Feb 10, 2019

@fabpot

fabpot approved these changes Feb 12, 2019

@fabpot fabpot force-pushed the nicolas-grekas:phpunit8 branch from 8324cd6 to 1077df6 Feb 12, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 12, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 1077df6 into symfony:3.4 Feb 12, 2019

0 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

fabpot added a commit that referenced this pull request Feb 12, 2019

bug #30124 Fix KernelTestCase compatibility for PhpUnit 8 (bis) (nico…
…las-grekas)

This PR was squashed before being merged into the 3.4 branch (closes #30124).

Discussion
----------

Fix KernelTestCase compatibility for PhpUnit 8 (bis)

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Follow up of #30084 and @Tobion's comment there.

Fabbot failure is a false-positive.

Commits
-------

1077df6 Fix KernelTestCase compatibility for PhpUnit 8 (bis)

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:phpunit8 branch Feb 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment