New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] add back test after fixing it #30132

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

xabbuh commented Feb 10, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29934 (comment)
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Feb 10, 2019

@xabbuh xabbuh force-pushed the xabbuh:pr-29934 branch from be44272 to 0daeba8 Feb 10, 2019

@fabpot

fabpot approved these changes Feb 12, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 12, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 0daeba8 into symfony:3.4 Feb 12, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 12, 2019

minor #30132 [Form] add back test after fixing it (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] add back test after fixing it

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29934 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

0daeba8 add back test after fixing it

@xabbuh xabbuh deleted the xabbuh:pr-29934 branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment