New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PropertyAccessorInterface instead of PropertyAccessor #30136

Merged
merged 1 commit into from Feb 12, 2019

Conversation

@nick-zh
Copy link
Contributor

nick-zh commented Feb 11, 2019

[Validator] [Constraints] use PropertyAccessorInterface instead of PropertyAccessor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30133 (partially)
License MIT
Doc PR none
@xabbuh

xabbuh approved these changes Feb 11, 2019

@xabbuh xabbuh added the Validator label Feb 11, 2019

@chalasr chalasr added this to the next milestone Feb 11, 2019

@ogizanagi
Copy link
Member

ogizanagi left a comment

Good catch. Should we backport to 3.4 actually?

@fabpot

fabpot approved these changes Feb 12, 2019

Copy link
Member

fabpot left a comment

Looks like something for 3.4 indeed.

@nick-zh

This comment has been minimized.

Copy link
Contributor Author

nick-zh commented Feb 12, 2019

I don't know how you guys usually handle this, but since the change is very small and probably has no negative impact, it could make sense. Let me know if i should open PR's for other branches as well.

@fabpot fabpot changed the base branch from master to 3.4 Feb 12, 2019

@fabpot fabpot force-pushed the nick-zh:master branch from 664a5f6 to 3e3ca9d Feb 12, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 12, 2019

Thank you @nick-zh.

@fabpot fabpot merged commit 3e3ca9d into symfony:3.4 Feb 12, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build cancelled
Details
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 12, 2019

bug #30136 use PropertyAccessorInterface instead of PropertyAccessor …
…(nick-zh)

This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #30136).

Discussion
----------

use PropertyAccessorInterface instead of PropertyAccessor

[Validator] [Constraints] use PropertyAccessorInterface instead of PropertyAccessor

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30133 (partially)
| License       | MIT
| Doc PR        | none

Commits
-------

3e3ca9d use PropertyAccessorInterface instead of PropertyAccessor

@chalasr chalasr modified the milestones: next, 3.4 Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment