Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish message with custom queue options : flags | attributes #30225

Merged
merged 3 commits into from Feb 21, 2019

Conversation

Projects
None yet
5 participants
@insidestyles
Copy link
Contributor

commented Feb 13, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

option for publish persistent message:
amqp://localhost/%2f/messages?queue[attributes][delivery_mode]=2&queue[flags]=1
or
options:

queue:

name: '%env(MESSENGER_QUEUE)%'
routing_key: '%env(MESSENGER_ROUTING_KEY)%'
attributes:

delivery_mode: 2

flags: 1

@nicolas-grekas nicolas-grekas added this to the next milestone Feb 16, 2019

$amqpExchange->expects($this->once())->method('publish')
->with('body', null, 1, ['delivery_mode' => 2, 'headers' => ['token' => 'uuid', 'type' => '*']]);
$connection = Connection::fromDsn('amqp://localhost/%2f/messages?queue[attributes][delivery_mode]=2&queue[attributes][headers][token]=uuid&queue[flags]=1', [], true, $factory);

This comment has been minimized.

Copy link
@OskarStark

OskarStark Feb 20, 2019

Contributor

line break for the parameters would be nice for further diffs and readability, otherwise 👍

@fabpot

fabpot approved these changes Feb 21, 2019

Copy link
Member

left a comment

@insidestyles Can you submit a PR on the docs for the new options?

@fabpot

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Thank you @insidestyles.

@fabpot fabpot merged commit 5e16053 into symfony:master Feb 21, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 21, 2019

feature #30225 publish message with custom queue options : flags | at…
…tributes (fedor.f, insidestyles)

This PR was merged into the 4.3-dev branch.

Discussion
----------

publish message with custom queue options : flags | attributes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

option for publish persistent message:
`amqp://localhost/%2f/messages?queue[attributes][delivery_mode]=2&queue[flags]=1`
or
options:
>queue:
>>name: '%env(MESSENGER_QUEUE)%'
>>routing_key: '%env(MESSENGER_ROUTING_KEY)%'
>>attributes:
>>>delivery_mode: 2

>>flags: 1

Commits
-------

5e16053 update test case for custom queue options
4532319 publish message with custom queue options : update ConnectionTest
6f9fdaf publish message with custom queue options : flags | attributes

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.