Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add element to ghost in Exception #30236
Let's make love (& good code) not war. Sorry for not submitting it at least yesterday, but hopefully you will accept it, and we will be able to merge today. This will allow us to add different addons on other special ocasions.
On personal side, I dedicate it, with lots of kisses, to my wife Martha.
If you like it, just
Feb 16, 2019
Just sharing my opinion about this proposal: even if the idea is cute ... I wouldn't have merged this for several reasons, mainly:
I'd agree with what you said in your last comment: showing something different on Symfony's birthday (which is considered to be: October 18th 2005 at 16:27:36). That's a truly universal and non-controversial event. But I wouldn't display any other event, so I'd remove the one merged in this PR. Thanks.
@javiereguiluz I would just like to underline that I had no intensions of hurting anybody's beliefs or feelings.
Althougth I take my job as a developer very seriously, I wanted to add a little fun and human touch to a great tool, which I - like most of us here - use almost every day. I thougth, that it would be nice, if hardcoding developer noticed something special about the exception message on a few selected occasions. I started with this one, because I believe it to be a universal message - I mean love in general, not just Valentine's Day.
As to the code itself, I don't believe that these few additional lines complicate it in a way, which would increase a chance of failure. Nevertheless, I am always open to any suggestions from an experienced developer and Symfony contributor like you. I have prepared a new addon to celebrate Symfony's anniversaries, and I am looking forward to your comments (#30326).