Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lost namespace in eval #30245

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
None yet
6 participants
@fizzka
Copy link
Contributor

fizzka commented Feb 14, 2019

Bugfix:
phpunit8 tearDown() declaration

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

oups :)

@@ -34,9 +35,6 @@ protected function tearDown(): void
*/
trait KernelShutdownOnTearDownTrait
{
/**
* @return void

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Feb 14, 2019

Member

please keep the annotation

This comment has been minimized.

Copy link
@fizzka

fizzka Feb 14, 2019

Author Contributor

reverted!

Show resolved Hide resolved src/Symfony/Bundle/FrameworkBundle/Test/KernelShutdownOnTearDownTrait.php

fizzka added a commit to fizzka/symfony that referenced this pull request Feb 14, 2019

@Tobion

Tobion approved these changes Feb 14, 2019

@fabpot

fabpot approved these changes Feb 16, 2019

@fabpot fabpot force-pushed the fizzka:patch-1 branch from 0f322e8 to 8743a1a Feb 16, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 16, 2019

Thank you @fizzka.

@fabpot fabpot merged commit 8743a1a into symfony:4.2 Feb 16, 2019

0 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

fabpot added a commit that referenced this pull request Feb 16, 2019

bug #30245 fix lost namespace in eval (fizzka)
This PR was squashed before being merged into the 4.2 branch (closes #30245).

Discussion
----------

fix lost namespace in eval

Bugfix:
phpunit8 tearDown() declaration

Commits
-------

8743a1a fix lost namespace in eval

nicolas-grekas added a commit that referenced this pull request Feb 16, 2019

bug #30245 fix lost namespace in eval (fizzka)
This PR was squashed before being merged into the 4.2 branch (closes #30245).

Discussion
----------

fix lost namespace in eval

Bugfix:
phpunit8 tearDown() declaration

Commits
-------

8743a1a fix lost namespace in eval
@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 16, 2019

added to 3.4 in da325fc

fabpot added a commit that referenced this pull request Feb 18, 2019

Merge branch '3.4' into 4.2
* 3.4:
  [TwigBridge] Fix test
  Remove unnecessary ProgressBar stdout writes (fixes flickering)
  [Validator] improve translations for albanian ("sq") locale
  [VarDumper] fix serializing Stub instances
  Don't resolve the Deprecation error handler mode until a deprecation is triggered
  bug #30245 fix lost namespace in eval (fizzka)
  [Twig] removed usage of non-namespaced classes
  added missing dot
  Update validators.lt.xlf
  #30172 Add the missing validation translations for the Luxembourgish …
  [Debug][ErrorHandler] Preserve next error handler

@xabbuh xabbuh added this to the 3.4 milestone Feb 18, 2019

nicolas-grekas added a commit that referenced this pull request Feb 19, 2019

Merge branch '4.2'
* 4.2:
  [Console] Fix command testing with missing inputs
  [Validator] Sync no/nb translation files
  [Translation] Added a script to display the status of translations
  [Validator] Added missing translations for Norwegian (\"no\") locale #30179
  [Security\Guard] bump lowest version of security-core
  [TwigBridge] Fix test
  Remove unnecessary ProgressBar stdout writes (fixes flickering)
  [Validator] improve translations for albanian ("sq") locale
  [VarDumper] fix serializing Stub instances
  [Validator] Added missing use statement for UnexpectedTypeException
  Don't resolve the Deprecation error handler mode until a deprecation is triggered
  bug #30245 fix lost namespace in eval (fizzka)
  fix lost namespace in eval
  [Twig] removed usage of non-namespaced classes
  added missing dot
  Update validators.lt.xlf
  #30172 Add the missing validation translations for the Luxembourgish …
  [Debug][ErrorHandler] Preserve next error handler

@fabpot fabpot referenced this pull request Mar 3, 2019

Merged

Release v4.2.4 #30431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.