Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug][ErrorHandler] Preserve next error handler #30264

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
None yet
3 participants
@fancyweb
Copy link
Contributor

fancyweb commented Feb 15, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30140
License MIT
Doc PR -

Thank you @cuchac

Getting the current error handler in the error handler itself actually works. If you try to see the content of the $currentErrorHandler var however, you will always see null. That's why I thought it was impossible. Because I did not test from end to end until today.

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

Thanks for having a second look.

[Debug][ErrorHandler] Preserve next error handler
Co-authored-by: Joe <cuchac@email.cz>

@fancyweb fancyweb force-pushed the fancyweb:preserve-next-error-handler branch from 6621e8e to a8b3434 Feb 16, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 16, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 16, 2019

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit a8b3434 into symfony:3.4 Feb 16, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 16, 2019

bug #30264 [Debug][ErrorHandler] Preserve next error handler (fancyweb)
This PR was merged into the 3.4 branch.

Discussion
----------

[Debug][ErrorHandler] Preserve next error handler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30140
| License       | MIT
| Doc PR        | -

Thank you @cuchac

Getting the current error handler in the error handler itself actually works. If you try to see the content of the `$currentErrorHandler` var however, you will always see `null`. That's why I thought it was impossible. Because I did not test from end to end until today.

Commits
-------

a8b3434 [Debug][ErrorHandler] Preserve next error handler

This was referenced Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.