Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] add option to render NumberType as type="number" #30267

Merged
merged 1 commit into from Feb 21, 2019

Conversation

@xabbuh
Copy link
Member

commented Feb 16, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #8106
License MIT
Doc PR symfony/symfony-docs#10997

@xabbuh xabbuh force-pushed the xabbuh:issue-8106 branch from 0b54b40 to 42e8f5e Feb 21, 2019

@fabpot

fabpot approved these changes Feb 21, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 42e8f5e into symfony:master Feb 21, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 21, 2019

feature #30267 [Form] add option to render NumberType as type="number…
…" (xabbuh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Form] add option to render NumberType as type="number"

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8106
| License       | MIT
| Doc PR        | symfony/symfony-docs#10997

Commits
-------

42e8f5e add option to render NumberType as type="number"

@xabbuh xabbuh deleted the xabbuh:issue-8106 branch Feb 21, 2019

wouterj added a commit to symfony/symfony-docs that referenced this pull request Mar 3, 2019

feature #10997 [Form] document the NumberType html5 option (xabbuh)
This PR was merged into the master branch.

Discussion
----------

[Form] document the NumberType html5 option

see symfony/symfony#30267

Commits
-------

bc5ac28 document the NumberType html5 option

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.