Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Fix Descriptor throwing on non existent parent #30294

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
4 participants
@GuilhemN
Copy link
Contributor

GuilhemN commented Feb 18, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets nelmio/NelmioApiDocBundle#1470
License MIT
Doc PR

The Descriptor throws an exception when it encounters a class having a non existent parent, see nelmio/NelmioApiDocBundle#1470 for the record.

@nicolas-grekas nicolas-grekas changed the title Fix Descriptor throwing on non existent parent [FrameworkBundle] Fix Descriptor throwing on non existent parent Feb 20, 2019

@nicolas-grekas nicolas-grekas merged commit 6b354cc into symfony:4.2 Feb 20, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Feb 20, 2019

bug #30294 [FrameworkBundle] Fix Descriptor throwing on non existent …
…parent (GuilhemN)

This PR was merged into the 4.2 branch.

Discussion
----------

[FrameworkBundle] Fix Descriptor throwing on non existent parent

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | nelmio/NelmioApiDocBundle#1470  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |

The Descriptor throws an exception when it encounters a class having a non existent parent, see nelmio/NelmioApiDocBundle#1470 for the record.

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

6b354cc Fix Descriptor throwing on non existent parent

@GuilhemN GuilhemN deleted the GuilhemN:fixissue branch Feb 22, 2019

@fabpot fabpot referenced this pull request Mar 3, 2019

Merged

Release v4.2.4 #30431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.