Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] add link to source next to class names #30301

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Copy link
Member

commented Feb 19, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This PR adds a ^ next to language identifiers (class and callback names) both on the Web and on the CLI. Clicking it opens the IDE to the target source code:

Eg in the profiler:
image

And in the CLI:
image

@nicolas-grekas nicolas-grekas added this to the next milestone Feb 19, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:vd-link branch from ca4cb48 to ffc52fb Feb 19, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:vd-link branch 4 times, most recently from 9731815 to bcb29a2 Feb 19, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:vd-link branch from bcb29a2 to 5fcd6b1 Feb 19, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2019

Now green with greater BC.

@fabpot

fabpot approved these changes Feb 21, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 5fcd6b1 into symfony:master Feb 21, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 21, 2019

feature #30301 [VarDumper] add link to source next to class names (ni…
…colas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[VarDumper] add link to source next to class names

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR adds a `^` next to language identifiers (class and callback names) both on the Web and on the CLI. Clicking it opens the IDE to the target source code:

Eg in the profiler:
![image](https://user-images.githubusercontent.com/243674/53021031-900c4380-3458-11e9-9439-260ff11f0910.png)

And in the CLI:
![image](https://user-images.githubusercontent.com/243674/53021092-b16d2f80-3458-11e9-9f03-cdab59da4585.png)

Commits
-------

5fcd6b1 [VarDumper] add link to source next to class names
@ro0NL

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

@nicolas-grekas seems nested objects are not linked :( perhaps due the max. depth setting..

image

the nested Role has a link, whereas SecurityUser doesnt. Any hint? :)

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

No hint why sorry, would need to be investigated.

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:vd-link branch Feb 25, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.