Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Fixed duplicate UUID #30324

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
4 participants
@ralfkuehnel
Copy link
Contributor

ralfkuehnel commented Feb 20, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30285
License MIT
Doc PR N/A

Fixes the TOO_HIGH_ERROR constant had the same value in two different constraints: LessThan and LessThanOrEqual.

@fabpot

fabpot approved these changes Feb 21, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 21, 2019

Thank you @ralfkuehnel.

@fabpot fabpot merged commit 0bd5dd8 into symfony:3.4 Feb 21, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 21, 2019

bug #30324 [Validator] Fixed duplicate UUID (ralfkuehnel)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Fixed duplicate UUID

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30285
| License       | MIT
| Doc PR        | N/A

Fixes the `TOO_HIGH_ERROR` constant had the same value in two different constraints: `LessThan` and `LessThanOrEqual`.

Commits
-------

0bd5dd8 [Validator] Fixed duplicate UUID
@javiereguiluz

This comment has been minimized.

Copy link
Member

javiereguiluz commented Feb 21, 2019

Thanks Ralf! If you did this change cloning the repo on your local machine and working with Git in your terminal, I'd love to know if you had any problem. Also, if you followed the Symfony contribution guide, I'd like to know if there was any confusing instruction on it. If you have any comments, you can reach me via email or Slack. Thanks again for your contribution!

@ralfkuehnel

This comment has been minimized.

Copy link
Contributor Author

ralfkuehnel commented Feb 21, 2019

@javiereguiluz I have followed the Symfony contribution guide to make the change on my local machine! It was straight forward, no problems! Already looking forward to make my next contribution! :)

This was referenced Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.