Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] rename parent_form() to form_parent() #30357

Merged
merged 1 commit into from Feb 23, 2019

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

commented Feb 23, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR symfony/symfony-docs#11049

We got some feedback on the blog post that form_parent() would be better
for consistency with all the existing form_*() functions. I think that
user has a point about that.

rename parent_form() to form_parent()
We got some feedback on the blog post that form_parent() would be better
for consistency with all the existing form_*() functions. I think that
user has a point about that.
@fabpot

fabpot approved these changes Feb 23, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 057d177 into symfony:master Feb 23, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 23, 2019

feature #30357 [TwigBridge] rename parent_form() to form_parent() (xa…
…bbuh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[TwigBridge] rename parent_form() to form_parent()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#11049

We got some feedback on the blog post that form_parent() would be better
for consistency with all the existing form_*() functions. I think that
user has a point about that.

Commits
-------

057d177 rename parent_form() to form_parent()

@xabbuh xabbuh deleted the xabbuh:pr-28812 branch Feb 23, 2019

xabbuh added a commit to symfony/symfony-docs that referenced this pull request Feb 23, 2019

minor #11049 rename parent_form() to form_parent() (xabbuh)
This PR was merged into the master branch.

Discussion
----------

rename parent_form() to form_parent()

symfony/symfony#30357

Commits
-------

f9e3559 rename parent_form() to form_parent()

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.