Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] be able to specify the input format for times #30358

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
7 participants
@xabbuh
Copy link
Member

commented Feb 23, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR symfony/symfony-docs#10882

This expands the work started in #29887 to also allow to configure the input format for string inputs in the TimeType.

Show resolved Hide resolved src/Symfony/Component/Form/CHANGELOG.md Outdated

@xabbuh xabbuh force-pushed the xabbuh:custom-time-input-form branch from 878298d to 2d9bc18 Feb 25, 2019

@sstok

sstok approved these changes Mar 3, 2019

@fabpot

fabpot approved these changes Mar 3, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 2d9bc18 into symfony:master Mar 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 3, 2019

feature #30358 [Form] be able to specify the input format for times (…
…xabbuh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Form] be able to specify the input format for times

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This expands the work started in #29887 to also allow to configure the input format for string inputs in the `TimeType`.

Commits
-------

2d9bc18 be able to specify the input format for times

@xabbuh xabbuh deleted the xabbuh:custom-time-input-form branch Mar 3, 2019

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Mar 7, 2019

minor #10882 [Form] Add input_format option to DateType, DateTimeType…
… and TimeType (fancyweb)

This PR was squashed before being merged into the master branch (closes #10882).

Discussion
----------

[Form] Add input_format option to DateType, DateTimeType and TimeType

Related Symfony PRs : symfony/symfony#29887 and symfony/symfony#30358

Commits
-------

8fc1b53 [Form] Add input_format option to DateType, DateTimeType and TimeType

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.