[FrameworkBundle] Removed eval() from KernelShutdownOnTearDownTrait #30364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fabpot.io failure seems to be a false positive (the script reads the typehint from the first definition and complains about the docblock of the second definition). |
nicolas-grekas
approved these changes
Feb 24, 2019
|
You should report the crash to phpstan then. |
ogizanagi
approved these changes
Feb 24, 2019
|
Thank you @skalpa. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 24, 2019
…arDownTrait (skalpa) This PR was merged into the 4.2 branch. Discussion ---------- [FrameworkBundle] Removed eval() from KernelShutdownOnTearDownTrait | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Apart from triggering the #30362 bug, the `eval()` block from #30124 also broke my workflow: static code analyzers don't like this, and the trait even crashes PHPStan. It may also bring up other compatibility issues to other people (ie: I know companies that completely disable `eval()` on their servers). As it was only required to keep the trait compatible with PHP 5.x, it is unnecessary on 4.x that requires PHP 7.1+, and this PR removes it on the 4.2 branch. Commits ------- 324b70a Removed eval() from KernelShutdownOnTearDownTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from triggering the #30362 bug, the
eval()block from #30124 also broke my workflow: static code analyzers don't like this, and the trait even crashes PHPStan.It may also bring up other compatibility issues to other people (ie: I know companies that completely disable
eval()on their servers).As it was only required to keep the trait compatible with PHP 5.x, it is unnecessary on 4.x that requires PHP 7.1+, and this PR removes it on the 4.2 branch.