Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][Routing] allow boolean container parameters for routes #30379

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
5 participants
@dmaicher
Copy link
Contributor

dmaicher commented Feb 25, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30366
License MIT
Doc PR symfony/symfony-docs#11059

This fixes #30366 and adds support for boolean container parameters in route conditions, defaults etc.

@OskarStark

This comment has been minimized.

Copy link
Contributor

OskarStark commented Feb 25, 2019

I like it, can you please send a doc PR? 🙏

@dmaicher

This comment has been minimized.

Copy link
Contributor Author

dmaicher commented Feb 26, 2019

I like it, can you please send a doc PR? pray

sure 👍 wondering what exactly to add there 😄

https://symfony.com/doc/master/routing/service_container_parameters.html

Should it be one of those "NEW... since Symfony 4.3 you can also use boolean parameters" box?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Feb 26, 2019

Not sure myself how/if this should be documented :)

@OskarStark

This comment has been minimized.

Copy link
Contributor

OskarStark commented Feb 26, 2019

Yes you should add a .. versionadded:: 4.3 directive 👍

@fabpot

fabpot approved these changes Mar 3, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 4, 2019

Thank you @dmaicher.

@fabpot fabpot merged commit 21f4e38 into symfony:master Mar 4, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 4, 2019

feature #30379 [FrameworkBundle][Routing] allow boolean container par…
…ameters for routes (dmaicher)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle][Routing] allow boolean container parameters for routes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30366
| License       | MIT
| Doc PR        | symfony/symfony-docs#11059

This fixes #30366 and adds support for boolean container parameters in route conditions, defaults etc.

Commits
-------

21f4e38 [FrameworkBundle][Routing] allow boolean container parameters for routes

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Mar 15, 2019

minor #11059 [FrameworkBundle][Routing] allow boolean container param…
…eters for routes (dmaicher)

This PR was merged into the master branch.

Discussion
----------

[FrameworkBundle][Routing] allow boolean container parameters for routes

See symfony/symfony#30379

Commits
-------

d89122c Update service_container_parameters.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.