Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] toolbar: invisible route name in Firefox #30383

Conversation

Projects
None yet
6 participants
@inmarelibero
Copy link
Contributor

inmarelibero commented Feb 26, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29858
License MIT
Doc PR -

This fixes #29858, fixing a bug that prevents Route name displaying in debug toolbar on Firefox

@ro0NL

This comment has been minimized.

Copy link
Contributor

ro0NL commented Feb 26, 2019

im still seeing the blue dots (#29858 (comment))

both chrome/ff

image

@inmarelibero

This comment has been minimized.

Copy link
Contributor Author

inmarelibero commented Feb 26, 2019

@ro0NL I can't see those blue dots, do you have a better screen than https://user-images.githubusercontent.com/1047696/53398635-6009f680-39aa-11e9-805b-0df52d6e2226.png, or indicate better where they are ?

@ro0NL

This comment has been minimized.

Copy link
Contributor

ro0NL commented Feb 26, 2019

normal
image

hover
image

better?

i think it happens because the text is wrapped in an <a> element.

The following additional patch solves it for me:

diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
index 9c1cad2..f42e150 100644
--- a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
+++ b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
@@ -103,6 +103,7 @@
 .sf-toolbar-block > a:hover {
     display: block;
     text-decoration: none;
+    color: inherit;
 }
 
 .sf-toolbar-block span {
@inmarelibero

This comment has been minimized.

Copy link
Contributor Author

inmarelibero commented Feb 26, 2019

thanks @ro0NL, I would't have noticed in a hundred years, you can check the screenshot
schermata 2019-02-26 alle 16 56 56

should be everything good now

@ro0NL

ro0NL approved these changes Feb 26, 2019

@fabpot

fabpot approved these changes Feb 28, 2019

@fabpot fabpot force-pushed the inmarelibero:issue_29858_toolbar_invisible_route_name_in_firefox branch from bb8e266 to 6b6bd45 Feb 28, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Feb 28, 2019

Thank you @inmarelibero.

@fabpot fabpot merged commit 6b6bd45 into symfony:4.2 Feb 28, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Feb 28, 2019

bug #30383 [WebProfilerBundle] toolbar: invisible route name in Firef…
…ox (inmarelibero)

This PR was squashed before being merged into the 4.2 branch (closes #30383).

Discussion
----------

[WebProfilerBundle] toolbar: invisible route name in Firefox

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29858
| License       | MIT
| Doc PR        | -

This fixes #29858, fixing a bug that prevents Route name displaying in debug toolbar on Firefox

Commits
-------

6b6bd45 [WebProfilerBundle] toolbar: invisible route name in Firefox

@inmarelibero inmarelibero deleted the inmarelibero:issue_29858_toolbar_invisible_route_name_in_firefox branch Feb 28, 2019

@inmarelibero

This comment has been minimized.

Copy link
Contributor Author

inmarelibero commented Mar 1, 2019

thank you all, I'm happy

@fabpot fabpot referenced this pull request Mar 3, 2019

Merged

Release v4.2.4 #30431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.