Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] undeprecate the RoleHierarchyInterface #30388

Merged
merged 1 commit into from Mar 23, 2019

Conversation

Projects
None yet
5 participants
@xabbuh
Copy link
Member

commented Feb 26, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22048 (comment)
License MIT
Doc PR

Instead of deprecating the interface it is sufficient to deprecate its
getReachableRoles() method and add a new getReachableRoleNames() method
in Symfony 5.

@xabbuh xabbuh added this to the next milestone Feb 26, 2019

@xabbuh xabbuh force-pushed the xabbuh:pr-22048 branch 3 times, most recently from e147a56 to 8cc37de Feb 26, 2019

@xabbuh xabbuh force-pushed the xabbuh:pr-22048 branch 2 times, most recently from 22f39c7 to fb602ce Mar 22, 2019

undeprecate the RoleHierarchyInterface
Instead of deprecating the interface it is sufficient to deprecate its
getReachableRoles() method and add a new getReachableRoleNames() method
in Symfony 5.

@xabbuh xabbuh force-pushed the xabbuh:pr-22048 branch from fb602ce to 2d3f2b7 Mar 22, 2019

@fabpot

fabpot approved these changes Mar 23, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

Thank you @xabbuh.

@fabpot fabpot merged commit 2d3f2b7 into symfony:master Mar 23, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 23, 2019

feature #30388 [Security] undeprecate the RoleHierarchyInterface (xab…
…buh)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Security] undeprecate the RoleHierarchyInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22048 (comment)
| License       | MIT
| Doc PR        |

Instead of deprecating the interface it is sufficient to deprecate its
getReachableRoles() method and add a new getReachableRoleNames() method
in Symfony 5.

Commits
-------

2d3f2b7 undeprecate the RoleHierarchyInterface

@xabbuh xabbuh deleted the xabbuh:pr-22048 branch Mar 23, 2019

fabpot added a commit that referenced this pull request Apr 6, 2019

bug #30886 [Workflow] Fixed Guard Listener usage of RoleHierarchyInte…
…rface (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] Fixed Guard Listener usage of RoleHierarchyInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

EUFOSSA

related to #30388

Commits
-------

a12b359 [Workflow] Fixed Guard Listener usage of RoleHierarchyInterface

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.