Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Fix UrlGenerator::generate to return an empty string instead of null #30390

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
7 participants
@eborges78
Copy link

commented Feb 27, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30306
License MIT

Fix #30306 : Controller::generateUrl() must be of the type string, null returned

@xabbuh

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

We would also need to update the docblock of the ConfigurableRequirementsInterface where null is explicitly documented.

@eborges78 eborges78 changed the title [FrameworkBundle] fix #30306 [FrameworkBundle] Fix UrlGenerator::generate to return an empty string instead of null Feb 27, 2019

@eborges78 eborges78 force-pushed the eborges78:ticket_30306 branch from 606729a to 6471c00 Feb 27, 2019

@HeahDude
Copy link
Member

left a comment

👍

@fabpot

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

This should be merged in 3.4 if we consider it as a bug fix.

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

After thinking about it a bit more, I would rather merge it in master and add a note in the changelogs about the change.

@eborges78 eborges78 changed the base branch from 4.2 to master Mar 4, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

@eborges78 Can you rebase on current master instead of merging? Merge commits forbids us from merging the PR. Thank you.

@eborges78 eborges78 force-pushed the eborges78:ticket_30306 branch 2 times, most recently from b6aa261 to b921200 Mar 4, 2019

@nicolas-grekas
Copy link
Member

left a comment

lgtm, with minor comment

Show resolved Hide resolved UPGRADE-4.3.md Outdated

@eborges78 eborges78 force-pushed the eborges78:ticket_30306 branch from de59984 to 0a59b42 Mar 4, 2019

@xabbuh

xabbuh approved these changes Mar 4, 2019

@fabpot

fabpot approved these changes Mar 4, 2019

@fabpot fabpot force-pushed the eborges78:ticket_30306 branch from 0a59b42 to c5b1247 Mar 4, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Thank you @eborges78.

@fabpot fabpot merged commit c5b1247 into symfony:master Mar 4, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 4, 2019

feature #30390 [FrameworkBundle] Fix UrlGenerator::generate to return…
… an empty string instead of null (Emmanuel BORGES)

This PR was squashed before being merged into the 4.3-dev branch (closes #30390).

Discussion
----------

[FrameworkBundle] Fix UrlGenerator::generate to return an empty string instead of null

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30306
| License       | MIT

Fix #30306 : Controller::generateUrl() must be of the type string, null returned

Commits
-------

c5b1247 [FrameworkBundle] Fix UrlGenerator::generate to return an empty string instead of null

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.