Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes" #30461

Open
wants to merge 3 commits into
base: 4.2
from

Conversation

Projects
None yet
3 participants
@eborges78
Copy link

eborges78 commented Mar 6, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30453
License MIT

The GetSetMethodNormalizer class correctly ignores the attributes specified in "ignored_attributes"

@eborges78 eborges78 force-pushed the eborges78:ticket_30453 branch from 0d28a1d to 1b5cf88 Mar 6, 2019

Emmanuel BORGES

@eborges78 eborges78 force-pushed the eborges78:ticket_30453 branch from 79639d9 to 24f77a0 Mar 6, 2019

@nicolas-grekas nicolas-grekas changed the title Fix getSetMethodNormalizer to correctly ignore the attributes specifi… Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes" Mar 7, 2019

Show resolved Hide resolved UPGRADE-4.2.md Outdated
@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

Could you add a test case please?

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Mar 7, 2019

Emmanuel BORGES

@eborges78 eborges78 force-pushed the eborges78:ticket_30453 branch 2 times, most recently from c16690e to 4772a9e Mar 7, 2019

Emmanuel BORGES

@eborges78 eborges78 force-pushed the eborges78:ticket_30453 branch from 4772a9e to 997adef Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.