Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a hyperlink to interfaces/classes that can be autowired #30469

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
6 participants
@SerkanYildiz
Copy link
Contributor

SerkanYildiz commented Mar 6, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

Added hyperlink to definition of interfaces/classes that can be used for autowiring.
But I need help with:

  • the aliases are becoming hyperlinks too, but shouldn't.
    It's outputting <fg=yellow;href=phpstorm://open?file=filepath&line=17>Symfony\Contracts\Translation\TranslatorInterface</> <fg=cyan>(translator.default)</>

  • it currently works with phpstorm because it's hardcoded but it should work with framework.ide option, but don't know what the best approach is to support that config option.

@SerkanYildiz SerkanYildiz force-pushed the SerkanYildiz:add-hyperlinks-for-autowirable-services branch 2 times, most recently from c697efb to 0b27826 Mar 6, 2019

@SerkanYildiz SerkanYildiz changed the title Create a hyperlink for interfaces/classes that can be autowired Create a hyperlink to interfaces/classes that can be autowired Mar 7, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 7, 2019

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

Thank you, I was hoping PRs on the topics, you're one of the first! There are many more places like this where linking could be nice :)

@SerkanYildiz

This comment has been minimized.

Copy link
Contributor Author

SerkanYildiz commented Mar 7, 2019

Hi @nicolas-grekas,

Thanks for your review. I still have the problem with that the service alias is getting linked too. Do you know where I should look at?

edit: might be a problem of zsh (I think it assumes that cache.app is a url)

@SerkanYildiz SerkanYildiz force-pushed the SerkanYildiz:add-hyperlinks-for-autowirable-services branch from ef540ed to a45dafb Mar 10, 2019

@SerkanYildiz

This comment has been minimized.

Copy link
Contributor Author

SerkanYildiz commented Mar 12, 2019

Status: Needs Review

@javiereguiluz
Copy link
Member

javiereguiluz left a comment

Nice feature! Thank you Serkan.

@nicolas-grekas nicolas-grekas force-pushed the SerkanYildiz:add-hyperlinks-for-autowirable-services branch from a45dafb to a3dfcee Mar 15, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 15, 2019

Thank you @SerkanYildiz.

@nicolas-grekas nicolas-grekas merged commit a3dfcee into symfony:master Mar 15, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Mar 15, 2019

feature #30469 Create a hyperlink to interfaces/classes that can be a…
…utowired (SerkanYildiz)

This PR was squashed before being merged into the 4.3-dev branch (closes #30469).

Discussion
----------

Create a hyperlink to interfaces/classes that can be autowired

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Added hyperlink to definition of interfaces/classes that can be used for autowiring.
But I need help with:
- the aliases are becoming hyperlinks too, but shouldn't.
It's outputting `<fg=yellow;href=phpstorm://open?file=filepath&line=17>Symfony\Contracts\Translation\TranslatorInterface</> <fg=cyan>(translator.default)</>`

- it currently works with phpstorm because it's hardcoded but it should work with framework.ide option, but don't know what the best approach is to support that config option.

Commits
-------

a3dfcee Create a hyperlink to interfaces/classes that can be autowired

@SerkanYildiz SerkanYildiz deleted the SerkanYildiz:add-hyperlinks-for-autowirable-services branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.