Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] fixes #30491

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 8, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Spotted while playing with the client.
There is an issue with 307/308 redirects + streamed body that is not fixed here; use string bodies for now.
I'm going to look for a solution in another PR.

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 8, 2019

@fabpot

fabpot approved these changes Mar 8, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-fix branch from 5323649 to 903b992 Mar 8, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-fix branch from 903b992 to 3eca2b4 Mar 8, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 8, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 3eca2b4 into symfony:master Mar 8, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 8, 2019

bug #30491 [HttpClient] fixes (nicolas-grekas)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpClient] fixes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Spotted while playing with the client.
There is an issue with 307/308 redirects + streamed body that is not fixed here; use string bodies for now.
I'm going to look for a solution in another PR.

Commits
-------

3eca2b4 [HttpClient] fixes

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-fix branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.