Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] replace "nullable" env processor by improving the "default" one #30504

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
7 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 9, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Neither nullable nor default are released yet.
I propose to replace the nullable processor (see #29767) with an improved default one (from #28976).
%env(default::FOO)% now defaults to null when the env var doesn't exist or compares to false".

ping @jderusse @bpolaszek

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-env-default-proc branch from 22823d2 to d6a1871 Mar 10, 2019

@bpolaszek

This comment has been minimized.

Copy link
Contributor

bpolaszek commented Mar 10, 2019

But it was my 1st PR! 😥

(French contributors will remind "mais t'avais dit qu'on ferait des knacki!")

More seriously, that's a good idea 🙂 thank you @nicolas-grekas !

@ro0NL

ro0NL approved these changes Mar 10, 2019

@ogizanagi
Copy link
Member

ogizanagi left a comment

Great. I like this one much more :)

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-env-default-proc branch from d6a1871 to c50aad2 Mar 10, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Mar 10, 2019

@jderusse @bpolaszek would you mind sending a doc PR please? (see #10722)

@jderusse

This comment has been minimized.

Copy link
Contributor

jderusse commented Mar 10, 2019

@fabpot

fabpot approved these changes Mar 10, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 10, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit c50aad2 into symfony:master Mar 10, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 10, 2019

feature #30504 [DI] replace "nullable" env processor by improving the…
… "default" one (nicolas-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[DI] replace "nullable" env processor by improving the "default" one

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Neither `nullable` nor `default` are released yet.
I propose to replace the `nullable` processor (see #29767) with an improved `default` one (from #28976).
`%env(default::FOO)%` now defaults to `null` when the env var doesn't exist or compares to false".

ping @jderusse @bpolaszek

Commits
-------

c50aad2 [DI] replace "nullable" env processor by improving the "default" one

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Mar 11, 2019

minor #11127 Document Default env processor with null fallback (jderu…
…sse)

This PR was merged into the master branch.

Discussion
----------

Document Default env processor with null fallback

Document the fallback to `null`

PR: symfony/symfony#30504

Commits
-------

309bd58 Document Default env processor with null fallback

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-env-default-proc branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.