Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] remove deprecation triggered when using Twig 2.7 #30506

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 10, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Needs twigphp/Twig#2874
Should make the CI green on 3.4.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 10, 2019

@nicolas-grekas nicolas-grekas requested a review from xabbuh as a code owner Mar 10, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-twig-deprec branch 2 times, most recently from 65a5ba9 to 611e415 Mar 10, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-twig-deprec branch from 611e415 to c17a5b2 Mar 10, 2019

@nicolas-grekas nicolas-grekas merged commit c17a5b2 into symfony:3.4 Mar 10, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Mar 10, 2019

bug #30506 [TwigBridge] remove deprecation triggered when using Twig …
…2.7 (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] remove deprecation triggered when using Twig 2.7

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Needs twigphp/Twig#2874
Should make the CI green on 3.4.

Commits
-------

c17a5b2 [TwigBridge] remove deprecation triggered when using Twig 2.7

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-twig-deprec branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.