Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] Fixed XML options resolution #30507

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
4 participants
@HeahDude
Copy link
Member

HeahDude commented Mar 10, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

Found this bug while adding tests in #30501. I need it to be merged upward so it can get green there.
Thanks!

@HeahDude HeahDude force-pushed the HeahDude:fix-routing-xml-loader branch from 64d8c99 to 53a6ff8 Mar 10, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 10, 2019

@fabpot

fabpot approved these changes Mar 11, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 11, 2019

Thank you @HeahDude.

@fabpot fabpot merged commit 53a6ff8 into symfony:3.4 Mar 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 11, 2019

bug #30507 [Routing] Fixed XML options resolution (Jules Pietri)
This PR was merged into the 3.4 branch.

Discussion
----------

[Routing] Fixed XML options resolution

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Found this bug while adding tests in #30501. I need it to be merged upward so it can get green there.
Thanks!

Commits
-------

53a6ff8 [Routing] Fixed XML options resolution

@HeahDude HeahDude deleted the HeahDude:fix-routing-xml-loader branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.