Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] removed a useless var #30510

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
4 participants
@HeahDude
Copy link
Member

HeahDude commented Mar 10, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

This was never documented, we should rely on $routes->import() instead.

Jules Pietri
@fabpot

fabpot approved these changes Mar 11, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 11, 2019

Good catch, thanks @HeahDude.

@fabpot fabpot merged commit 10c1313 into symfony:3.4 Mar 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 11, 2019

minor #30510 [Routing] removed a useless var (Jules Pietri)
This PR was merged into the 3.4 branch.

Discussion
----------

[Routing] removed a useless var

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

This was never documented, we should rely on `$routes->import()` instead.

Commits
-------

10c1313 [Routing] removed a useless var

@HeahDude HeahDude deleted the HeahDude:useless-var branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.