Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] fix using argument $php of new PhpProcess() #30511

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 10, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

The current logic makes no sense. 3.4 is fine.

@fabpot

fabpot approved these changes Mar 11, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 11, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit aa6e585 into symfony:4.2 Mar 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 11, 2019

bug #30511 [Process] fix using argument $php of new PhpProcess() (nic…
…olas-grekas)

This PR was merged into the 4.2 branch.

Discussion
----------

[Process] fix using argument $php of new PhpProcess()

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The current logic makes no sense. 3.4 is fine.

Commits
-------

aa6e585 [Process] fix using argument $php of new PhpProcess()

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:proc-fix branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.