Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Only delete one key at a time when on Predis + Cluster #30515

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
4 participants
@andrerom
Copy link
Contributor

andrerom commented Mar 11, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

Makes sure deletes when on Predis Cluster is only done one by one as it's not able to send the keys to right cluster node like RedisCluster can.

This is backport of logic from 4.x to fix this. With one tweak; make sure to only do this when on cluster so not all Predis users pay the penalty for it.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 11, 2019

@stof

stof approved these changes Mar 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 11, 2019

Thank you @andrerom.

@nicolas-grekas nicolas-grekas merged commit f5ece20 into symfony:3.4 Mar 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Mar 11, 2019

bug #30515 [Cache] Only delete one key at a time when on Predis + Clu…
…ster (andrerom)

This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] Only delete one key at a time when on Predis + Cluster

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Makes sure deletes when on Predis  Cluster is only done one by one as it's not able to send the keys to right cluster node like RedisCluster can.

_This is backport of logic from 4.x to fix this. With one tweak; make sure to only do this when on cluster so not all Predis users pay the penalty for it._

Commits
-------

f5ece20 [Cache] Only delete one key at a time when on Predis + Cluster

@andrerom andrerom deleted the andrerom:cache_single_del_predis_cluster branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.