Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers #30518

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@andrerom
Copy link
Contributor

andrerom commented Mar 11, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

This is slimmed down version of: #28269 (many of the fixes there are already part of 3.4)

Does:

  • Adds test coverage for Predis with RedisCluster
  • Removes usage of key versioning when on RedisCluster, besides performance aspect of that it simplifies / aligning clear() handling across all clients
  • reuse doDelete() from clear to make sure we call singular del calls when in predis cluster
[Cache] Fix perf when using RedisCluster by reducing roundtrips to th…
…e servers

This is slimmed down version of: #28269 _(many of the fixes here are already part of 3.4)_

Adds:
- Test coverage for Predis with RedisCluster
- Removes usage of key versioning when on RedisCluster, besides performance aspect of that simplify / aligning clear() handling across cases

@andrerom andrerom force-pushed the andrerom:redis_cluster_versioning_fixes branch from 2d75184 to dacf179 Mar 11, 2019

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Mar 12, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 13, 2019

Thank you @andrerom.

@nicolas-grekas nicolas-grekas merged commit dacf179 into symfony:3.4 Mar 13, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Mar 13, 2019

bug #30518 [Cache] Fix perf when using RedisCluster by reducing round…
…trips to the servers (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This is slimmed down version of: #28269 _(many of the fixes there are already part of 3.4)_

Does:
- Adds test coverage for Predis with RedisCluster
- Removes usage of key versioning when on RedisCluster, besides performance aspect of that it simplifies / aligning clear() handling across all clients
- reuse doDelete() from clear to make sure we call singular del calls when in predis cluster

Commits
-------

dacf179 [Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers

@andrerom andrerom deleted the andrerom:redis_cluster_versioning_fixes branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.