Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Fixed BC break with `MarkingStoreInterface::setMarking()` #30530

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
4 participants
@lyrixx
Copy link
Member

lyrixx commented Mar 12, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #30524
License MIT
Doc PR
Show resolved Hide resolved UPGRADE-5.0.md Outdated
Show resolved Hide resolved src/Symfony/Component/Workflow/Workflow.php Outdated
Show resolved Hide resolved UPGRADE-4.3.md Outdated

@lyrixx lyrixx force-pushed the lyrixx:w-context-bc branch from 2e892c2 to 4f0c5a8 Mar 12, 2019

@lyrixx

This comment has been minimized.

Copy link
Member Author

lyrixx commented Mar 12, 2019

@xabbuh @nicolas-grekas Thanks for your feedback. I addressed them. But the trick with the extra argument does not work for me :/

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Mar 12, 2019

MultipleStateMarkingStore, MultipleStateMarkingStore and SingleStateMarkingStore need the same approach also, they still break BC for now.

@lyrixx lyrixx force-pushed the lyrixx:w-context-bc branch from 750999c to ccd4b18 Mar 13, 2019

@lyrixx

This comment has been minimized.

Copy link
Member Author

lyrixx commented Mar 13, 2019

@nicolas-grekas Good catch. I removed the thirs param on both implem (not used anyway). More over, I will deprecate theses implemems in another PR

@lyrixx lyrixx force-pushed the lyrixx:w-context-bc branch from ccd4b18 to e3c6b11 Mar 13, 2019

@lyrixx lyrixx force-pushed the lyrixx:w-context-bc branch from e3c6b11 to 7a94e5e Mar 13, 2019

@lyrixx lyrixx merged commit 7a94e5e into symfony:master Mar 13, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

lyrixx added a commit that referenced this pull request Mar 13, 2019

bug #30530 [Workflow] Fixed BC break with `MarkingStoreInterface::set…
…Marking()` (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] Fixed BC break with `MarkingStoreInterface::setMarking()`

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #30524
| License       | MIT
| Doc PR        |

Commits
-------

7a94e5e [Workflow] Fixed BC break with `MarkingStoreInterface::setMarking()`

@lyrixx lyrixx deleted the lyrixx:w-context-bc branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.