Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Make exceptions public #30549

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
4 participants
@dunglas
Copy link
Member

dunglas commented Mar 13, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR n/a

Makes it easier to implement the interface. See api-platform/core#2608

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 13, 2019

@fabpot

fabpot approved these changes Mar 17, 2019

@fabpot fabpot force-pushed the dunglas:non-internal-exceptions branch from 9f985b4 to 928d774 Mar 17, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 17, 2019

Thank you @dunglas.

@fabpot fabpot merged commit 928d774 into symfony:master Mar 17, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 17, 2019

minor #30549 [HttpClient] Make exceptions public (dunglas)
This PR was squashed before being merged into the 4.3-dev branch (closes #30549).

Discussion
----------

[HttpClient] Make exceptions public

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no<!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

Makes it easier to implement the interface. See api-platform/core#2608

Commits
-------

928d774 [HttpClient] Make exceptions public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.