Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Sort components in travis CI #30555

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@GaryPEGEOT
Copy link
Contributor

GaryPEGEOT commented Mar 13, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR n/a

Get the components sorted alphabetically in Travis better readability

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 13, 2019

@@ -68,7 +68,7 @@ before_install:
export PHPUNIT=$(readlink -f ./phpunit)
export PHPUNIT_X="$PHPUNIT --exclude-group tty,benchmark,intl-data"
export COMPOSER_UP='composer update --no-progress --no-suggest --ansi'
export COMPONENTS=$(find src/Symfony -mindepth 2 -type f -name phpunit.xml.dist -printf '%h\n')
export COMPONENTS=$(find src/Symfony -mindepth 2 -type f -name phpunit.xml.dist -printf '%h\n' | sort)

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Mar 13, 2019

Member

They're already sorted - but the output is in random order because tests run in parallel. we don't want to change that.

This comment has been minimized.

@GaryPEGEOT

GaryPEGEOT Mar 13, 2019

Author Contributor

The command find src/Symfony -mindepth 2 -type f -name phpunit.xml.dist -printf '%h\n' gave me an unsorted the output:

src/Symfony/Contracts
src/Symfony/Bundle/TwigBundle
src/Symfony/Bundle/WebServerBundle
src/Symfony/Bundle/WebProfilerBundle
src/Symfony/Bundle/SecurityBundle
src/Symfony/Bundle/FrameworkBundle
src/Symfony/Bundle/DebugBundle
src/Symfony/Bridge/ProxyManager
src/Symfony/Bridge/PhpUnit
src/Symfony/Bridge/Twig
src/Symfony/Bridge/Doctrine
src/Symfony/Bridge/Monolog
src/Symfony/Component/Cache
src/Symfony/Component/Translation
src/Symfony/Component/Security/Core
src/Symfony/Component/Security/Http
src/Symfony/Component/Security
src/Symfony/Component/Security/Guard
src/Symfony/Component/Security/Csrf
src/Symfony/Component/HttpKernel
src/Symfony/Component/Yaml
src/Symfony/Component/OptionsResolver
src/Symfony/Component/Config
src/Symfony/Component/PropertyAccess
src/Symfony/Component/Mime
src/Symfony/Component/WebLink
src/Symfony/Component/HttpFoundation
src/Symfony/Component/Lock
src/Symfony/Component/Serializer
src/Symfony/Component/Process
src/Symfony/Component/Console
src/Symfony/Component/EventDispatcher
src/Symfony/Component/Asset
src/Symfony/Component/ExpressionLanguage
src/Symfony/Component/Workflow
src/Symfony/Component/Ldap
src/Symfony/Component/BrowserKit
src/Symfony/Component/PropertyInfo
src/Symfony/Component/VarDumper
src/Symfony/Component/Stopwatch
src/Symfony/Component/Routing
src/Symfony/Component/Dotenv
src/Symfony/Component/Debug
src/Symfony/Component/Inflector
src/Symfony/Component/Templating
src/Symfony/Component/DomCrawler
src/Symfony/Component/DependencyInjection
src/Symfony/Component/Form
src/Symfony/Component/Filesystem
src/Symfony/Component/Intl
src/Symfony/Component/CssSelector
src/Symfony/Component/Messenger
src/Symfony/Component/HttpClient
src/Symfony/Component/VarExporter
src/Symfony/Component/Finder
src/Symfony/Component/Validator

But I didn't know that parallelization mess it up too :)

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Mar 13, 2019

Member

sorting is left to the filesystem then :)
but since parallelization changes the order anyway, not sure this is worth it

This comment has been minimized.

@GaryPEGEOT

GaryPEGEOT Mar 13, 2019

Author Contributor

Not worth it as it give partial results

@GaryPEGEOT GaryPEGEOT closed this Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.