Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] fix LockRegistry #30576

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 15, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -
  • Locking doesn't work right now, because of this missing return statement.
    I can't provide a useful test case, because this is effective only when race conditions happen...
  • Writing the value should happen within the boundaries of the lock.
  • The final keyword is really missing, there are zero reasons to extend this class, adding it asap will make it clear and will unlock progress on this class.
  • Lastly, a type-hint fix is shipped here also.

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Mar 15, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cahce-lock branch 3 times, most recently from ebd7194 to 13f40b7 Mar 15, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cahce-lock branch from 13f40b7 to f49df4a Mar 15, 2019

@nicolas-grekas nicolas-grekas merged commit f49df4a into symfony:4.2 Mar 15, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Mar 15, 2019

bug #30576 [Cache] fix LockRegistry (nicolas-grekas)
This PR was merged into the 4.2 branch.

Discussion
----------

[Cache] fix LockRegistry

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

- Locking doesn't work right now, because of this missing return statement.
I can't provide a useful test case, because this is effective only when race conditions happen...
- Writing the value should happen within the boundaries of the lock.
- The `final` keyword is really missing, there are zero reasons to extend this class, adding it asap will make it clear and will unlock progress on this class.
- Lastly, a type-hint fix is shipped here also.

Commits
-------

f49df4a [Cache] fix LockRegistry

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:cahce-lock branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.