Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using AMQP auto-setup in all cases, not just in debug #30579

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
7 participants
@weaverryan
Copy link
Member

commented Mar 15, 2019

Q A
Branch? master
Bug fix? yes and no
New feature? no
BC breaks? yes
Deprecations? no->
Tests pass? yes
Fixed tickets Related to #29476
License MIT
Doc PR TODO

Currently AMQP does auto-setup of queues/exchanges in dev-mode only. That's a problem for 2 reasons:

  1. Behavior in prod is drastically different... and actually... there's not currently a way I know of (easily) to set things up on prod.

  2. One of the properties of AMQP is that you typically DO want things to be set up at runtime, as you need them - you usually do want auto-setup.

This changes the behavior to auto-setup true always.

@lyrixx

lyrixx approved these changes Mar 15, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 16, 2019

@nicolas-grekas
Copy link
Member

left a comment

(with minor typo)
another step forward for Messenger :)

@weaverryan weaverryan force-pushed the weaverryan:amqp-always-auto-setup-default branch from 069ab5f to 503c209 Mar 17, 2019

@weaverryan

This comment has been minimized.

Copy link
Member Author

commented Mar 17, 2019

Ready now!

@sroze

sroze approved these changes Mar 17, 2019

@sroze

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Good point 👍

@fabpot

fabpot approved these changes Mar 17, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Thank you @weaverryan.

@fabpot fabpot merged commit 503c209 into symfony:master Mar 17, 2019

3 of 5 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 17, 2019

feature #30579 Using AMQP auto-setup in all cases, not just in debug …
…(weaverryan)

This PR was merged into the 4.3-dev branch.

Discussion
----------

Using AMQP auto-setup in all cases, not just in debug

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes and no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no->
| Tests pass?   | yes
| Fixed tickets | Related to #29476
| License       | MIT
| Doc PR        | TODO

Currently AMQP does auto-setup of queues/exchanges in dev-mode only. That's a problem for 2 reasons:

1) Behavior in prod is drastically different... and actually... there's not currently a way I know of (easily) to set things up on prod.

2) One of the properties of AMQP is that you typically DO want things to be set up at runtime, as you need them - you usually *do* want auto-setup.

This changes the behavior to auto-setup true always.

Commits
-------

503c209 Using AMQP auto-setup in all cases, not just in debug

@weaverryan weaverryan deleted the weaverryan:amqp-always-auto-setup-default branch Mar 17, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.