Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Display a nice error when connection fail #30583

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
5 participants
@lyrixx
Copy link
Member

commented Mar 16, 2019

Q A
Branch? master
Bug fix? no
New feature? kind of
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Before:

image

Now:

image

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 16, 2019

@lyrixx lyrixx force-pushed the lyrixx:messenger-connect-fail branch from c73c919 to eac014f Mar 17, 2019

@fabpot

fabpot approved these changes Mar 17, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Thank you @lyrixx.

@fabpot fabpot merged commit eac014f into symfony:master Mar 17, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 17, 2019

feature #30583 [Messenger] Display a nice error when connection fail …
…(lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] Display a nice error when connection fail

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | kind of
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

### Before:

![image](https://user-images.githubusercontent.com/408368/54469293-6bc12f80-4796-11e9-897c-f07504132214.png)

### Now:

![image](https://user-images.githubusercontent.com/408368/54469287-5c41e680-4796-11e9-80ac-692899693542.png)

Commits
-------

eac014f [Messenger] Display a nice error when connection fail

@lyrixx lyrixx deleted the lyrixx:messenger-connect-fail branch Mar 17, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.