Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] add RealHttpKernel: handle requests with HttpClientInterface #30625

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Mar 21, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This commit is directly extracted from #30602 by @fabpot

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hk-real branch from c0904fa to b579b02 Mar 21, 2019

'headers' => $headers,
'body' => $body,
'max_redirects' => 0,
] + $request->attributes->get('http_client_options', []));

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Mar 21, 2019

Author Member

This line is the only difference with #30602: an http_client_options attribute to allow passing options to the underlying HTTP client when needed.

@fabpot

fabpot approved these changes Mar 21, 2019

@fabpot fabpot merged commit b579b02 into symfony:master Mar 21, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 21, 2019

feature #30625 [HttpKernel] add RealHttpKernel: handle requests with …
…HttpClientInterface (fabpot)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpKernel] add RealHttpKernel: handle requests with HttpClientInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This commit is directly extracted from #30602 by @fabpot

Commits
-------

b579b02 [HttpKernel] add RealHttpKernel: handle requests with HttpClientInterface

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hk-real branch Mar 25, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.