Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the serializer configurable by transport #30628

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
6 participants
@weaverryan
Copy link
Member

commented Mar 21, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #30293 (already closed, but I don't think this was reasonably possible before)
License MIT
Doc PR TODO - as many of the new messenger PRs will be done at once

Use cases:

  • #30293
  • Transport A will be consumed by your Symfony app (so native php serialization is cool) but transport B will be consumed by another app, so you want to serialize as JSON
  • Upgrading from Symfony 4.2 to 4.3. The change to the PhpSerialize means that messages that were sent to the queue on 4.2, will fail on 4.3. The solution is to use the old serializer in your config. This would allow you to make your existing transport use the old serializer, then migrate to a new transport using the new serializer (then remove the old one later).

Thanks!

@weaverryan weaverryan referenced this pull request Mar 21, 2019

Closed

[Messenger] Making it Shine #30540

30 of 36 tasks complete

@weaverryan weaverryan force-pushed the weaverryan:messenger-serializer-by-transport branch from 1fc3ef3 to e0b8cb7 Mar 21, 2019

@weaverryan weaverryan force-pushed the weaverryan:messenger-serializer-by-transport branch 2 times, most recently from e7ae82e to 79425a3 Mar 21, 2019

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 25, 2019

@weaverryan weaverryan force-pushed the weaverryan:messenger-serializer-by-transport branch 2 times, most recently from 8b46346 to f3e7aff Mar 28, 2019

@weaverryan

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

Ready to go again

Status: Needs review

@weaverryan weaverryan force-pushed the weaverryan:messenger-serializer-by-transport branch from f3e7aff to 2d71a11 Mar 29, 2019

@sroze sroze added the BC Break label Mar 31, 2019

@sroze

sroze approved these changes Mar 31, 2019

Show resolved Hide resolved src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md Outdated

@weaverryan weaverryan force-pushed the weaverryan:messenger-serializer-by-transport branch from 5396317 to 44c9e38 Mar 31, 2019

@weaverryan

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2019

Rebased and ready!

@weaverryan weaverryan force-pushed the weaverryan:messenger-serializer-by-transport branch from 44c9e38 to 7b66e39 Mar 31, 2019

@fabpot

fabpot approved these changes Mar 31, 2019

@fabpot fabpot force-pushed the weaverryan:messenger-serializer-by-transport branch from 7b66e39 to ef6f23e Mar 31, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

Thank you @weaverryan.

@fabpot fabpot merged commit ef6f23e into symfony:master Mar 31, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 31, 2019

feature #30628 Making the serializer configurable by transport (weave…
…rryan)

This PR was merged into the 4.3-dev branch.

Discussion
----------

Making the serializer configurable by transport

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30293 (already closed, but I don't think this was reasonably possible before)
| License       | MIT
| Doc PR        | TODO - as many of the new messenger PRs will be done at once

Use cases:
* #30293
* Transport A will be consumed by your Symfony app (so native php serialization is cool) but transport B will be consumed by another app, so you want to serialize as JSON
* Upgrading from Symfony 4.2 to 4.3. The change to the `PhpSerialize` means that messages that were sent to the queue on 4.2, will fail on 4.3. The solution is to use the old serializer in your config. This would allow you to make your existing transport use the old serializer, then migrate to a new transport using the new serializer (then remove the old one later).

Thanks!

Commits
-------

ef6f23e Making the serializer configurable by transport

@weaverryan weaverryan deleted the weaverryan:messenger-serializer-by-transport branch Mar 31, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.