Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] added CachingHttpClient #30629

Merged
merged 1 commit into from Mar 23, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Mar 21, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

The proposed CachingHttpClient uses HttpCache from the HttpKernel component to provide an HTTP-compliant cache.

If this is accepted, it could replace the corresponding part in #30602

Show resolved Hide resolved src/Symfony/Component/HttpClient/CachingHttpClient.php Outdated
Show resolved Hide resolved src/Symfony/Component/HttpClient/CachingHttpClient.php
$request = Request::create($url, $method);
$request->attributes->set('http_client_options', $options);
$request->headers->add($options['headers']);

This comment has been minimized.

Copy link
@fabpot

fabpot Mar 22, 2019

Member

You also need to add support for Cookies.

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Mar 22, 2019

Author Member

fixed

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-caching branch 4 times, most recently from 9981b83 to f6e4411 Mar 22, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-caching branch from f6e4411 to dae5686 Mar 22, 2019

@fabpot

fabpot approved these changes Mar 23, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit dae5686 into symfony:master Mar 23, 2019

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Mar 23, 2019

feature #30629 [HttpClient] added CachingHttpClient (fabpot)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[HttpClient] added CachingHttpClient

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The proposed `CachingHttpClient` uses `HttpCache` from the HttpKernel component to provide an HTTP-compliant cache.

If this is accepted, it could replace the corresponding part in #30602

Commits
-------

dae5686 [HttpClient] added CachingHttpClient

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-caching branch Mar 25, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.