Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Finder] Get filename without extension #30664

Merged

Conversation

Projects
None yet
6 participants
@antonch1989
Copy link
Contributor

commented Mar 24, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30655
License MIT
Doc PR
@OskarStark
Copy link
Contributor

left a comment

Thank you for this contribution, please fix the table in the PR header, because this is no bugfix, but a feature.

Show resolved Hide resolved src/Symfony/Component/Finder/SplFileInfo.php Outdated

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 25, 2019

@nicolas-grekas nicolas-grekas removed the Bug label Mar 25, 2019

@fabpot

fabpot approved these changes Mar 27, 2019

Copy link
Member

left a comment

LGTM, let's a minor comment.

Show resolved Hide resolved src/Symfony/Component/Finder/SplFileInfo.php Outdated

@fabpot fabpot force-pushed the antonch1989:issue-30655-filename-without-extension branch from 137f287 to 821e55a Mar 27, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Thank you @antonch1989.

@fabpot fabpot merged commit 821e55a into symfony:master Mar 27, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Mar 27, 2019

feature #30664 [Finder] Get filename without extension (antonch1989)
This PR was squashed before being merged into the 4.3-dev branch (closes #30664).

Discussion
----------

[Finder] Get filename without extension

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30655
| License       | MIT
| Doc PR        |

Commits
-------

821e55a [Finder] Get filename without extension
@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Thank you for this contribution, can you please add some documentation for this new feature?

@javiereguiluz

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

I find this method confusing. It's called getFilenameWithoutExtension() but sometimes it returns the filename + extension:

getFilenameWithoutExtension('foo.html');      // foo
getFilenameWithoutExtension('foo.html.twig'); // foo.html
getFilenameWithoutExtension('foo.tar.gz');    // foo.tar

I expected foo as the returned value in all cases.

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.