Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameter `prefetching` for AMQP connection #30671

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@f2r
Copy link
Contributor

commented Mar 24, 2019

Add prefetching connection parameter to setup channel prefetch count.

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

When setting up AMQP transport connection, it can be interesting to configure prefetching on a channel, which is not currently possible.

@weaverryan weaverryan referenced this pull request Mar 24, 2019

Closed

[Messenger] Making it Shine #30540

30 of 36 tasks complete
@sroze

sroze approved these changes Mar 25, 2019

Copy link
Member

left a comment

Looks good to me 👍

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 25, 2019

@f2r f2r requested review from lyrixx and xabbuh as code owners Mar 26, 2019

@stof

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

The diff seems a mess. Are you sure that your feature branch is based on master ?

@f2r f2r force-pushed the f2r:prefetching branch from 8dcd0d9 to cf4d68e Mar 26, 2019

fabpot added a commit that referenced this pull request Mar 26, 2019

minor #30702 [Messenger] rename `auto-setup` amqp option into `auto_s…
…etup` (dmaicher)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Messenger] rename `auto-setup` amqp option into `auto_setup`

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See #30671 (comment)

Commits
-------

6263e48 [Messenger] rename `auto-setup` amqp option into `auto_setup`
@fabpot

fabpot approved these changes Mar 27, 2019

Copy link
Member

left a comment

Left a minor comment. Also, can you squash the commits?

@stof

stof approved these changes Mar 28, 2019

Add optional parameter `prefetching` in connection configuration, to …
…setup channel prefetch count

Co-Authored-By: f2r <frederic.bouchery+github@gmail.com>

@sroze sroze force-pushed the f2r:prefetching branch from cf4d68e to 47777ee Mar 28, 2019

@sroze

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

Thank you @f2r.

@sroze sroze merged commit 47777ee into symfony:master Mar 28, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

sroze added a commit that referenced this pull request Mar 28, 2019

feature #30671 Add optional parameter `prefetching` for AMQP connecti…
…on (fbouchery)

This PR was merged into the 4.3-dev branch.

Discussion
----------

Add optional parameter `prefetching` for AMQP connection

Add prefetching connection parameter to setup channel prefetch count.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

When setting up AMQP transport connection, it can be interesting to configure prefetching on a channel, which is not currently possible.

Commits
-------

47777ee Add optional parameter `prefetching` in connection configuration, to setup channel prefetch count

@weaverryan weaverryan referenced this pull request Mar 28, 2019

Open

[Messenger][4.3] Tracker for changes #11236

1 of 25 tasks complete

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.